You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Adelwageeh96 (via GitHub)" <gi...@apache.org> on 2026/09/02 11:10:36 UTC

Re: [PR] NIFI-14869: Add MSSQL MERGE-based upsert via new DatabaseDialectService [nifi]

Adelwageeh96 commented on PR #11442:
URL: https://github.com/apache/nifi/pull/11442#issuecomment-5508615495

   Hello @exceptionfactory , thanks for the detailed feedback. I've made all three changes:
   
   1. Moved MSSQLDatabaseDialectService (and its test) into the nifi-database-dialect-service module, alongside                            
   StandardDatabaseDialectService, and registered it in that module's META-INF/services instead of nifi-standard-processors.
   2. Removed the unnecessary public modifiers from TestMSSQLDatabaseDialectService.
   3. Converted the multi-line MERGE assertion strings in the test to text blocks instead of + concatenation.
   
   Latest commit: 39d308c004. Ready for another look whenever you have a chance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org