[jira] [Commented] (MESOS-4421) Document that /reserve, /create-volumes endpoints can return misleading "success"

["Artem Harutyunyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127221#comment-15127221 ] 

Artem Harutyunyan commented on MESOS-4421:
------------------------------------------

Hey [~greggomann], could you please take a look at this one? Jie is fine with committing it once it has a Ship It from you. 

> Document that /reserve, /create-volumes endpoints can return misleading "success"
> ---------------------------------------------------------------------------------
>
>                 Key: MESOS-4421
>                 URL: https://issues.apache.org/jira/browse/MESOS-4421
>             Project: Mesos
>          Issue Type: Task
>          Components: documentation, master
>            Reporter: Neil Conway
>            Assignee: Neil Conway
>              Labels: documentation, endpoint, mesosphere, persistent-volumes, reservations
>
> The docs for the {{/reserve}} endpoint say:
> {noformat}
> 200 OK: Success (the requested resources have been reserved).
> {noformat}
> This is not true: the master returns {{200}} when the request has been validated and a {{CheckpointResourcesMessage}} has been sent to the agent, but the master does not attempt to verify that the message has been received or that the agent successfully checkpointed. Same behavior applies to {{/unreserve}}, {{/create-volumes}}, and {{/destroy-volumes}}.
> We should _either_:
> 1. Accurately document what {{200}} return code means.
> 2. Change the implementation to wait for the agent's next checkpoint to succeed (and to include the effect of the operation) before returning success to the HTTP client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)