You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "li-boxuan (via GitHub)" <gi...@apache.org> on 2023/08/20 17:46:44 UTC
[GitHub] [tinkerpop] li-boxuan opened a new pull request, #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
li-boxuan opened a new pull request, #2212:
URL: https://github.com/apache/tinkerpop/pull/2212
SparkGraphComputer uses StarGraph to represent an in-memory graph. EdgeFilter can be configured by users to drop unneeded edges, but the edge properties aren't dropped. This fixes this bug and greatly reduces memory footprint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] li-boxuan commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "li-boxuan (via GitHub)" <gi...@apache.org>.
li-boxuan commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1698433691
Retargeted 3.6-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1690832834
Thanks @li-boxuan, LGTM
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1697935771
> > are these changes only needed in 3.7?
> > if so then VOTE +1
>
> I am not sure which branch I should target, so I set master at the moment. Is 3.5 branch still being supported? If so, I could retarget this PR to 3.5 branch since it is technically a bug fix.
It seems like 3.5-dev is being phased out, so this can probably target 3.6-dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1692043291
are these changes only needed in 3.7?
if so then VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1685354872
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2212?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2212](https://app.codecov.io/gh/apache/tinkerpop/pull/2212?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (946ddc3) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/ce88ce1a8f576d5d2114154951bf009b7e0285a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ce88ce1) will **increase** coverage by `0.84%`.
> Report is 1570 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2212 +/- ##
============================================
+ Coverage 69.91% 70.75% +0.84%
============================================
Files 866 24 -842
Lines 41068 3567 -37501
Branches 5476 0 -5476
============================================
- Hits 28713 2524 -26189
+ Misses 10455 875 -9580
+ Partials 1900 168 -1732
```
[see 854 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2212/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] li-boxuan commented on pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "li-boxuan (via GitHub)" <gi...@apache.org>.
li-boxuan commented on PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212#issuecomment-1692706123
> are these changes only needed in 3.7?
>
> if so then VOTE +1
I am not sure which branch I should target, so I set master at the moment. Is 3.5 branch still being supported? If so, I could retarget this PR to 3.5 branch since it is technically a bug fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer merged pull request #2212: TINKERPOP-2986: [StarGraph] Drop edge properties when dropping edges
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2212:
URL: https://github.com/apache/tinkerpop/pull/2212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org