You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/01 07:34:14 UTC

[GitHub] [dolphinscheduler] hstdream opened a new pull request, #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

hstdream opened a new pull request, #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636

   
   
   ## Purpose of the pull request
   
   close #12002  close #11805
   
   
   ## Verify this pull request
   1.create worker group
   2.create workflow select workergroup
   3.delete worker group
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] calvinjiang closed pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by "calvinjiang (via GitHub)" <gi...@apache.org>.
calvinjiang closed pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.
URL: https://github.com/apache/dolphinscheduler/pull/12636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] hstdream commented on pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
hstdream commented on PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#issuecomment-1298148121

   in version 3.1.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#discussion_r1011039131


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml:
##########
@@ -195,4 +195,17 @@
         SELECT DISTINCT(id) as project_id
         FROM t_ds_project
     </select>
+    <select id="queryProcessDefinitionByWorkerGroupName" resultType="org.apache.dolphinscheduler.dao.entity.ProcessDefinition">
+        SELECT DISTINCT
+            pd.id, pd.code, pd.name
+        FROM
+            t_ds_process_task_relation ptr
+        JOIN t_ds_process_definition pd ON ptr.process_definition_code = pd.CODE
+        AND ptr.process_definition_version = pd.version
+        AND ptr.project_code = pd.project_code
+        JOIN t_ds_task_definition td ON ( ptr.pre_task_code = td.CODE AND ptr.pre_task_version = td.version )

Review Comment:
   Please don't use join.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] caishunfeng commented on pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#issuecomment-1299535999

   > I don't think this PR has solved this problem, the history version may still use the worker group. And we don't need to do these check, once the master cannot find the worker group, the task need to fail, rather than still retry. cc @SbloodyS @caishunfeng
   
   Yes, the history version may still use the worker group, but if we don't check for the current version, it will cause execute fail, I think it's not users want.
   If we check for the current version, when user switch workflow version, is it better try to check all dependent resources and give some tips? WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
hstdream commented on code in PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#discussion_r1011091110


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml:
##########
@@ -195,4 +195,17 @@
         SELECT DISTINCT(id) as project_id
         FROM t_ds_project
     </select>
+    <select id="queryProcessDefinitionByWorkerGroupName" resultType="org.apache.dolphinscheduler.dao.entity.ProcessDefinition">
+        SELECT DISTINCT
+            pd.id, pd.code, pd.name
+        FROM
+            t_ds_process_task_relation ptr
+        JOIN t_ds_process_definition pd ON ptr.process_definition_code = pd.CODE
+        AND ptr.process_definition_version = pd.version
+        AND ptr.project_code = pd.project_code
+        JOIN t_ds_task_definition td ON ( ptr.pre_task_code = td.CODE AND ptr.pre_task_version = td.version )

Review Comment:
   Thanks for the comments, but if the workflow in the online is deleted from the workergroup, it will cause the workflow to fail to run . cc @ruanwenjun @SbloodyS @caishunfeng .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#issuecomment-1298441580

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12636)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL)
   
   [![45.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '45.5%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_coverage&view=list) [45.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#issuecomment-1298441138

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12636)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12636&resolved=false&types=CODE_SMELL)
   
   [![45.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '45.5%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_coverage&view=list) [45.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12636&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org