You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/02 10:26:10 UTC
[GitHub] [spark] khalidmammadov opened a new pull request, #38074: [SPARK-38496][PYSPARK][TEST] Add unit tests for map functions
khalidmammadov opened a new pull request, #38074:
URL: https://github.com/apache/spark/pull/38074
### What changes were proposed in this pull request?
Adding missing Unit tests
### Why are the changes needed?
Increase test coverage for PySpark API
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
`python/run-tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38074: [SPARK-38496][PYSPARK][TEST] Add unit tests for map functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38074:
URL: https://github.com/apache/spark/pull/38074#discussion_r985385203
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -1072,6 +1072,44 @@ def test_binary_math_function(self):
for a, e in zip(df.first(), expected):
self.assertAlmostEqual(a, e, 5)
+ def test_map_functions(self):
+ from pyspark.sql import functions as F
Review Comment:
Let's move this import to the top, and add a comment like:
```python
def test_case(self):
# SPARK-12345: a short description of the test
...
```
See also https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] khalidmammadov commented on pull request #38074: [SPARK-38496][PYSPARK][TEST] Add unit tests for map functions
Posted by GitBox <gi...@apache.org>.
khalidmammadov commented on PR #38074:
URL: https://github.com/apache/spark/pull/38074#issuecomment-1264615381
@HyukjinKwon @itholic please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org