You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "derrickaw (via GitHub)" <gi...@apache.org> on 2025/05/06 21:06:16 UTC
[PR] reorder opt-out review comment [beam]
derrickaw opened a new pull request, #34872:
URL: https://github.com/apache/beam/pull/34872
Reorder the opt-out of review comment from:
```Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:
R: @claudevdm for label python.
R: @Abacn for label java.
Available commands:```
to:
```Assigning reviewers:
R: @claudevdm for label python.
R: @Abacn for label java.
Note: If you would like to opt out of this review, comment `assign to next reviewer`
Available commands:```
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reorder opt-out review comment [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34872:
URL: https://github.com/apache/beam/pull/34872#discussion_r2077568591
##########
scripts/ci/pr-bot/shared/commentStrings.ts:
##########
@@ -39,6 +39,8 @@ export function assignReviewer(labelToReviewerMapping: any): string {
}
}
+ commentString += "Note: If you would like to opt out of this review, comment `assign to next reviewer`.\n"
Review Comment:
We probably want some extra whitespace before this. Also, could you include it in the multiline string below instead of having multiple appends?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reorder opt-out review comment [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34872:
URL: https://github.com/apache/beam/pull/34872#issuecomment-2858351758
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reorder opt-out review comment [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #34872:
URL: https://github.com/apache/beam/pull/34872#discussion_r2077971007
##########
scripts/ci/pr-bot/shared/commentStrings.ts:
##########
@@ -39,6 +39,8 @@ export function assignReviewer(labelToReviewerMapping: any): string {
}
}
+ commentString += "Note: If you would like to opt out of this review, comment `assign to next reviewer`.\n"
Review Comment:
updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] reorder opt-out review comment [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #34872:
URL: https://github.com/apache/beam/pull/34872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org