You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/12 14:12:44 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1571: drivers: Change the location of the board specific driver's configuration option.

Ouss4 opened a new pull request #1571:
URL: https://github.com/apache/incubator-nuttx/pull/1571


   ## Summary
   Move the configuration to select a board specific drive folder to the common driver/Kconfig file.
   ## Impact
   We don't need to add that config for every boards/drivers we (will) have.
   ## Testing
   Spresense configs and some custom board configs.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1571: drivers: Change the location of the board specific driver's configuration option.

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1571:
URL: https://github.com/apache/incubator-nuttx/pull/1571#issuecomment-672897806


   I though we could also remove the dummy folder link and source the platform/Kconfig only if SPECIFIC_DRIVER is selected, but apprently we can't do this:
   ```
   if SPECIFIC_DRIVER
   source platform/Kconfig
   endif
   ```
   
   Is that true?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1571: drivers: Change the location of the board specific driver's configuration option.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1571:
URL: https://github.com/apache/incubator-nuttx/pull/1571


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 removed a comment on pull request #1571: drivers: Change the location of the board specific driver's configuration option.

Posted by GitBox <gi...@apache.org>.
Ouss4 removed a comment on pull request #1571:
URL: https://github.com/apache/incubator-nuttx/pull/1571#issuecomment-672897806


   I though we could also remove the dummy folder link and source the platform/Kconfig only if SPECIFIC_DRIVER is selected, but apprently we can't do this:
   ```
   if SPECIFIC_DRIVER
   source platform/Kconfig
   endif
   ```
   
   Is that true?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org