You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/02 15:53:28 UTC
[GitHub] [calcite] hsyuan opened a new pull request #1958: [CALCITE-3968] Disable JoinPushThroughJoinRule.left by default
hsyuan opened a new pull request #1958:
URL: https://github.com/apache/calcite/pull/1958
JIRA: CALCITE-3968
JoinPushThroughJoinRule.right does
(RS)T -> (RT)S
JoinPushThroughJoinRule.left does
(RS)T -> (TS)R
If JoinCommuteRule is enabled, only enabling JoinPushThroughJoinRule.right can
achieve the same alternative with JoinPushThroughJoinRule.left, vice versa
(suppose they are connected). So there is no need to enable left and right
instances at the same time, which will slow down the optimization dramatically,
e.g TPCH q05, q07 in TpchTest.java never finish. There is also the same bug
report from [1].
Meanwhile, JoinPushThroughJoinRule matches RelNode.class, which is unnecessary.
It should be just a group, or RelSet / RelSubset, as a place holder, because we
don't care about what exactly the top join's right child is. But since the rule
is designed to work with both HepPlanner and VolcanoPlanner, so just bear with
the slowness.
[1] https://lists.apache.org/thread.html/r195c267ef15f50aa21bbcefd7bf523f8bf2495b2345fd163e91e3c36%40%3Cdev.calcite.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan commented on pull request #1958: [CALCITE-3968] Disable JoinPushThroughJoinRule.right by default
Posted by GitBox <gi...@apache.org>.
hsyuan commented on pull request #1958:
URL: https://github.com/apache/calcite/pull/1958#issuecomment-628887415
Closing this PR, since this has been superseded by https://github.com/apache/calcite/pull/1976.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan closed pull request #1958: [CALCITE-3968] Disable JoinPushThroughJoinRule.right by default
Posted by GitBox <gi...@apache.org>.
hsyuan closed pull request #1958:
URL: https://github.com/apache/calcite/pull/1958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org