You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/17 00:16:46 UTC
Review Request 20430: Improve test Cluster::shutdown to destroy containers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20430/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Many tests (in particular slave recovery tests) leave containers running at the end of a test. This patch extends Cluster::Slaves::shutdown to query and destroy the containers for any slaves in the cluster, ensuring isolators can properly clean up everything.
Note: This is not done for slaves that are stopped (so we can actually do slave recovery tests!) so any test that completes without slaves but with containers still running must do this step manually - see the two modified tests.
Diffs
-----
src/tests/cluster.hpp 8479fe370d5a64cb2827b69b6f0c626b9d156d66
src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
Diff: https://reviews.apache.org/r/20430/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20430: Improve test Cluster::shutdown to destroy
containers.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20430/#review40751
-----------------------------------------------------------
Bad patch!
Reviews applied: [20430]
Failed command: git apply --index 20430.patch
Error:
error: patch failed: src/tests/cluster.hpp:20
error: src/tests/cluster.hpp: patch does not apply
- Mesos ReviewBot
On April 16, 2014, 10:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20430/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:17 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-976
> https://issues.apache.org/jira/browse/MESOS-976
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Many tests (in particular slave recovery tests) leave containers running at the end of a test. This patch extends Cluster::Slaves::shutdown to query and destroy the containers for any slaves in the cluster, ensuring isolators can properly clean up everything.
>
> Note: This is not done for slaves that are stopped (so we can actually do slave recovery tests!) so any test that completes without slaves but with containers still running must do this step manually - see the two modified tests.
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp 8479fe370d5a64cb2827b69b6f0c626b9d156d66
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20430: Improve test Cluster::shutdown to destroy
containers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20430/#review40941
-----------------------------------------------------------
Ship it!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/20430/#comment74255>
kill new line.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/20430/#comment74256>
kill new line.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/20430/#comment74257>
kill new line.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/20430/#comment74258>
kill new line.
- Vinod Kone
On April 16, 2014, 10:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20430/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:17 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-976
> https://issues.apache.org/jira/browse/MESOS-976
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Many tests (in particular slave recovery tests) leave containers running at the end of a test. This patch extends Cluster::Slaves::shutdown to query and destroy the containers for any slaves in the cluster, ensuring isolators can properly clean up everything.
>
> Note: This is not done for slaves that are stopped (so we can actually do slave recovery tests!) so any test that completes without slaves but with containers still running must do this step manually - see the two modified tests.
>
>
> Diffs
> -----
>
> src/tests/cluster.hpp 8479fe370d5a64cb2827b69b6f0c626b9d156d66
> src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
>
> Diff: https://reviews.apache.org/r/20430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20430: Improve test Cluster::shutdown to destroy
containers.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20430/
-----------------------------------------------------------
(Updated April 16, 2014, 10:17 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-976
https://issues.apache.org/jira/browse/MESOS-976
Repository: mesos-git
Description
-------
Many tests (in particular slave recovery tests) leave containers running at the end of a test. This patch extends Cluster::Slaves::shutdown to query and destroy the containers for any slaves in the cluster, ensuring isolators can properly clean up everything.
Note: This is not done for slaves that are stopped (so we can actually do slave recovery tests!) so any test that completes without slaves but with containers still running must do this step manually - see the two modified tests.
Diffs
-----
src/tests/cluster.hpp 8479fe370d5a64cb2827b69b6f0c626b9d156d66
src/tests/slave_recovery_tests.cpp 72b6d42f0895f10fed041a5a1351e79b003e2d1b
Diff: https://reviews.apache.org/r/20430/diff/
Testing
-------
Thanks,
Ian Downes