You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Guozhang Wang <wa...@gmail.com> on 2015/02/08 07:22:00 UTC

Re: Review Request 29468: Patch for KAFKA-1805

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review71572
-----------------------------------------------------------



clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117334>

    Is this intentional?



clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117335>

    Theoretically partitionId can be null also.


- Guozhang Wang


On Dec. 30, 2014, 12:37 a.m., Parth Brahmbhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 12:37 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
>     https://issues.apache.org/jira/browse/KAFKA-1805
>     https://issues.apache.org/jira/browse/KAFKA-1905
>     https://issues.apache.org/jira/browse/KAFKA-42
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29 
> 
> Diff: https://reviews.apache.org/r/29468/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Parth Brahmbhatt
> 
>