[GitHub] [spark] cloud-fan commented on a change in pull request #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #25134: [SPARK-28366][CORE] Logging in driver when loading single large unsplittable file
URL: https://github.com/apache/spark/pull/25134#discussion_r304844650
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala
 ##########
 @@ -207,6 +210,15 @@ class HadoopRDD[K, V](
       } else {
         allInputSplits
       }
+      if (inputSplits.length == 1 && inputSplits(0).isInstanceOf[FileSplit]) {
+        val fileSplit = inputSplits(0).asInstanceOf[FileSplit]
+        val path = fileSplit.getPath
+        if (Utils.isFileSplittable(path, codecFactory)
 
 Review comment:
   do we really need to know it's splittable or not? If Spark is scanning files with a single giant partition, it's going to be very slow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org