You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2012/02/15 14:56:59 UTC

[jira] [Created] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Upgrade framework for filesystem layouts
----------------------------------------

                 Key: BOOKKEEPER-172
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
             Project: Bookkeeper
          Issue Type: Improvement
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly
             Fix For: 4.1.0


Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215754#comment-13215754 ] 

Hudson commented on BOOKKEEPER-172:
-----------------------------------

Integrated in bookkeeper-trunk #374 (See [https://builds.apache.org/job/bookkeeper-trunk/374/])
    BOOKKEEPER-172: Upgrade framework for filesystem layouts (ivank via fpj) (Revision 1293342)

     Result = UNSTABLE
fpj : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/bin/bookkeeper
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java
* /zookeeper/bookkeeper/trunk/doc/bookkeeperConfig.textile

                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff, BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212485#comment-13212485 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-172:
----------------------------------------------------------



bq.  On 2012-02-21 06:26:00, fpj wrote:
bq.  > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java, line 22
bq.  > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line22>
bq.  >
bq.  >     Shouldn't this go into bookkeeper.tools?

No, this accesses bookie internals. If this were put in bookkeeper.tools, then bookie internals would have to be made public. 


bq.  On 2012-02-21 06:26:00, fpj wrote:
bq.  > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java, line 115
bq.  > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line115>
bq.  >
bq.  >     Sounds like we need documentation for this. It is ok if we are adding in BOOKKEEPER-163.

Documentation for the tool in general, or documentation for this object? This is the same configuration as the bookie server uses.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5225
-----------------------------------------------------------


On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3910/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 14:08:46)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-172.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/bin/bookkeeper b0629bd 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java PRE-CREATION 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3910/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212489#comment-13212489 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-172:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5238
-----------------------------------------------------------



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
<https://reviews.apache.org/r/3910/#comment11437>

    should it be a constant define?


- Sijie


On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3910/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 14:08:46)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-172.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/bin/bookkeeper b0629bd 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java PRE-CREATION 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3910/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-172:
----------------------------------

    Attachment: BOOKKEEPER-172.diff

Added doc
                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff, BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215642#comment-13215642 ] 

Sijie Guo commented on BOOKKEEPER-172:
--------------------------------------

+1 for the new patch. the document is good.
                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff, BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212400#comment-13212400 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-172:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5225
-----------------------------------------------------------


Looks good, I have a couple of minor comments. 


bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
<https://reviews.apache.org/r/3910/#comment11422>

    Shouldn't this go into bookkeeper.tools?



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java
<https://reviews.apache.org/r/3910/#comment11433>

    Sounds like we need documentation for this. It is ok if we are adding in BOOKKEEPER-163.


- fpj


On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3910/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 14:08:46)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-172.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/bin/bookkeeper b0629bd 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java PRE-CREATION 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3910/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212503#comment-13212503 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-172:
----------------------------------------------------------



bq.  On 2012-02-21 10:06:21, Sijie Guo wrote:
bq.  > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java, line 68
bq.  > <https://reviews.apache.org/r/3910/diff/1/?file=75146#file75146line68>
bq.  >
bq.  >     should it be a constant define?

No, unless we define it as LAYOUT_VERSION_1 which kinda defeats the purpose. I never what this number to be changed, so having a magic number here is fine in my opinion. 


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/#review5238
-----------------------------------------------------------


On 2012-02-15 14:08:46, Ivan Kelly wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3910/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-15 14:08:46)
bq.  
bq.  
bq.  Review request for bookkeeper.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.
bq.  
bq.  
bq.  This addresses bug BOOKKEEPER-172.
bq.      https://issues.apache.org/jira/browse/BOOKKEEPER-172
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bookkeeper-server/bin/bookkeeper b0629bd 
bq.    bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java PRE-CREATION 
bq.    bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3910/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ivan
bq.  
bq.


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-172:
----------------------------------

    Attachment: BOOKKEEPER-172.diff
    
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215570#comment-13215570 ] 

Flavio Junqueira commented on BOOKKEEPER-172:
---------------------------------------------

+1, thanks for the adding documentation, Ivan. Sijie, are you ok with this patch?
                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff, BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208490#comment-13208490 ] 

jiraposter@reviews.apache.org commented on BOOKKEEPER-172:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3910/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.


This addresses bug BOOKKEEPER-172.
    https://issues.apache.org/jira/browse/BOOKKEEPER-172


Diffs
-----

  bookkeeper-server/bin/bookkeeper b0629bd 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/3910/diff


Testing
-------


Thanks,

Ivan


                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-172) Upgrade framework for filesystem layouts

Posted by "Sijie Guo (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212609#comment-13212609 ] 

Sijie Guo commented on BOOKKEEPER-172:
--------------------------------------

> No, unless we define it as LAYOUT_VERSION_1 which kinda defeats the purpose. I never what this number to be > changed, so having a magic number here is fine in my opinion.

I am fine with that.
                
> Upgrade framework for filesystem layouts
> ----------------------------------------
>
>                 Key: BOOKKEEPER-172
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-172
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-172.diff
>
>
> Part of BOOKKEEPER-163. This improvement creates a framework to allow administrators to upgrade the filesystem layout of previous bookkeeper versions to be usable by the most recent software. The upgrade processes are currently empty until BOOKKEEPER-163 adds something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira