You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/15 09:56:58 UTC

[jira] [Commented] (SOLR-9868) RangeFacet : Use DocValues for accs and docSet collection instead of RangeQuery

    [ https://issues.apache.org/jira/browse/SOLR-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15750950#comment-15750950 ] 

ASF GitHub Bot commented on SOLR-9868:
--------------------------------------

GitHub user rustamhsmv opened a pull request:

    https://github.com/apache/lucene-solr/pull/125

    SOLR-9868 RangeFacet : Use DocValues for accs and docSet collection instead of RangeQuery

    RangeFacet initiates a range query for each range bucket to get the docSet. DocSet later used for accs collection.
    For singleValued numeric fields, we can use docValues to find the matching slots for each doc to collect accumulators while iterating over base docSet. If there is a subFacet, docSet per range bucket can be collected from base docSet as well.
    Gains :
    
        One iteration over base docSet vs querying over baseDocSet for each range bucket
        Memory saving If there is no subFacet, since per bucket docSet is not needed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rustamhsmv/lucene-solr rangeFacet

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 83337ac8431b70fb9f0abf4d90f2a1381a42f560
Author: Rustam Hashimov <rh...@microsoft.com>
Date:   2016-12-13T00:59:40Z

    -a

commit 558430ada340fb96d77a28d441737d168a0b9c31
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-13T08:52:31Z

    -a

commit 633884099267b6b98df2033807d8ccaf017d4194
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-14T01:51:57Z

    -a

commit 7b945aa8b75ef7680481646b75b14dc172f4734a
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-14T20:18:17Z

    -a

commit 6afdfba9a8dd74e47ae8b7effbcdba0242d839cf
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T00:17:39Z

    2 processors

commit 90826bd429c214170f3585ac898d49af0eb41e68
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T00:36:18Z

    Revert "2 processors"
    
    This reverts commit 6afdfba9a8dd74e47ae8b7effbcdba0242d839cf.

commit d93829348e7b92ae607e46e05ba7ea48ed6f5c71
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T01:16:22Z

    Minor refactoring

commit 3f13209648d28e0268fe3747d28039e3ae9bc8f3
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T01:23:20Z

    Merge branch 'master' into rangeFacet

commit 9c1270b6f910282e415d56d3317d9f66f192f2fe
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T03:31:17Z

    Do not collect docSet if there is not subFacet

commit 89475214abb10a6ee513d11997a94f69fddaeb15
Author: rustamhsmv <ru...@outlook.com>
Date:   2016-12-15T03:57:03Z

    comments

----


> RangeFacet : Use DocValues for accs and docSet collection instead of RangeQuery
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-9868
>                 URL: https://issues.apache.org/jira/browse/SOLR-9868
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Facet Module
>    Affects Versions: master (7.0)
>            Reporter: Rustam Hashimov
>             Fix For: master (7.0)
>
>
> RangeFacet initiates a range query for each range bucket to get the docSet. DocSet later used for accs collection.
> For singleValued numeric fields, we can use docValues to find the matching slots for each doc to collect accumulators while iterating over base docSet. If there is a subFacet, docSet per range bucket can be collected from base docSet as well. 
> Gains :
> - One iteration over base docSet vs querying over baseDocSet for each range bucket
> - Memory saving If there is no subFacet, since per bucket docSet is not needed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org