You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/01/14 21:21:47 UTC

[jira] Created: (MATH-476) [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0

[MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0
-------------------------------------------------------------------------

                 Key: MATH-476
                 URL: https://issues.apache.org/jira/browse/MATH-476
             Project: Commons Math
          Issue Type: Improvement
            Reporter: Sebb
            Priority: Minor


The FastMath class contains quite a few 'magic' numbers, not all of which are explained/documented.

For example, how is the number (-)4503599627370496.0 calculated?

IMO, all magic numbers should be replaced by constants with a descriptive name and explanatory Javadoc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Updated] (MATH-476) [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MATH-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated MATH-476:
-----------------------------

    Affects Version/s:     (was: 3.0)
        Fix Version/s: 3.1

Pushing out to 3.1 absent patch

> [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0
> -------------------------------------------------------------------------
>
>                 Key: MATH-476
>                 URL: https://issues.apache.org/jira/browse/MATH-476
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.1
>
>
> The FastMath class contains quite a few 'magic' numbers, not all of which are explained/documented.
> For example, how is the number (-)4503599627370496.0 calculated?
> IMO, all magic numbers should be replaced by constants with a descriptive name and explanatory Javadoc.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MATH-476) FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0

Posted by "Gilles (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MATH-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gilles updated MATH-476:
------------------------

    Fix Version/s:     (was: 3.1)
                   3.2
          Summary: FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0  (was: [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0)
    
> FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0
> ------------------------------------------------------------------
>
>                 Key: MATH-476
>                 URL: https://issues.apache.org/jira/browse/MATH-476
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 3.2
>
>
> The FastMath class contains quite a few 'magic' numbers, not all of which are explained/documented.
> For example, how is the number (-)4503599627370496.0 calculated?
> IMO, all magic numbers should be replaced by constants with a descriptive name and explanatory Javadoc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MATH-476) [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MATH-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated MATH-476:
----------------------

    Affects Version/s: 3.0
                       2.2

> [MATH] FastMath code contains 'magic' numbers, e.g. (-)4503599627370496.0
> -------------------------------------------------------------------------
>
>                 Key: MATH-476
>                 URL: https://issues.apache.org/jira/browse/MATH-476
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2, 3.0
>            Reporter: Sebb
>            Priority: Minor
>
> The FastMath class contains quite a few 'magic' numbers, not all of which are explained/documented.
> For example, how is the number (-)4503599627370496.0 calculated?
> IMO, all magic numbers should be replaced by constants with a descriptive name and explanatory Javadoc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.