You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/21 13:32:39 UTC

[GitHub] [incubator-kyuubi] shenbinglife opened a new issue #1951: [Bug] 当并发创建会话时，EngineRef判断当前引擎数量为空时，会不会导致并发创建引擎？

shenbinglife opened a new issue #1951:
URL: https://github.com/apache/incubator-kyuubi/issues/1951


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   当并发创建会话时，EngineRef判断当前引擎数量为空时，会不会导致并发创建引擎？
   
    getServerHost(zkClient, engineSpace).getOrElse {
           create(zkClient, extraEngineLog)
         }
   
   这段代码在并发上是不是有问题？ 
   
   ### Affects Version(s)
   
   1.5.0
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] zhouyifan279 commented on issue #1951: [Bug] 当并发创建会话时，EngineRef判断当前引擎数量为空时，会不会导致并发创建引擎？

Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on issue #1951:
URL: https://github.com/apache/incubator-kyuubi/issues/1951#issuecomment-1046911637


   不会。`org.apache.kyuubi.engine.EngineRef#create`中会获取分布式锁。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] zhouyifan279 edited a comment on issue #1951: [Bug] 当并发创建会话时，EngineRef判断当前引擎数量为空时，会不会导致并发创建引擎？

Posted by GitBox <gi...@apache.org>.
zhouyifan279 edited a comment on issue #1951:
URL: https://github.com/apache/incubator-kyuubi/issues/1951#issuecomment-1046911637


   不会。`org.apache.kyuubi.engine.EngineRef#create`中会获取分布式锁。
   
   PS：不确定的问题可以先在[Disscutions](https://github.com/apache/incubator-kyuubi/discussions)中创建问题。Issue中不适合做FAQ。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org