You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/06/29 15:58:06 UTC

[GitHub] [arrow] sgilmore10 commented on a diff in pull request #36383: GH-36173: [C++] Add lone high and low code-point test case for UTF8StringToUTF16

sgilmore10 commented on code in PR #36383:
URL: https://github.com/apache/arrow/pull/36383#discussion_r1246839563


##########
cpp/src/arrow/util/utf8_util_test.cc:
##########
@@ -416,6 +416,12 @@ TEST(UTF8StringToUTF16, Basics) {
 
   CheckInvalid("\xff");
   CheckInvalid("h\xc3");
+
+  // lone high-code point
+  CheckInvalid("\xed\xa0\x80");
+
+  // lone low-code point
+  CheckInvalid("\xed\0xb0\x81");

Review Comment:
   Good catch! Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org