You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/02/09 19:00:17 UTC

[GitHub] incubator-brooklyn pull request: code review fixes for CLI extensi...

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/510

    code review fixes for CLI extensions

    closing streams, deprecating old BrooklynDevelopmentModes, and release notes
    
    builds on #478 which was prematurely merged
    
    @neykov does this address all your comments?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn cli-ports-and-more

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #510
    
----
commit 02a6e551465c03307816e3800404fe5b78497f1c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-02-09T17:59:07Z

    code review fixes for CLI extensions
    
    closing streams, deprecating old BrooklynDevelopmentModes, and release notes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: code review fixes for CLI extensi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/510


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: code review fixes for CLI extensi...

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/510#issuecomment-73557296
  
    Yes, looks good for merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---