You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/03/01 13:08:18 UTC
[jira] [Commented] (COUCHDB-2943) Tray Refactor & Bugfix: does not
close after querying
[ https://issues.apache.org/jira/browse/COUCHDB-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173666#comment-15173666 ]
ASF subversion and git services commented on COUCHDB-2943:
----------------------------------------------------------
Commit b7c7865865a402bad836bc1f116184ad25b98a6a in couchdb-fauxton's branch refs/heads/master from [~robertkowalski]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-fauxton.git;h=b7c7865 ]
Trays: finish softmigration
Fix bug where the query panel stayed open after multiple clicks:
When opening the Options Tray in the all_docs view, clicking query
and then cancel, clicking Cancel in the Query Options panel
doesn't close it.
uses flux for state management of the tray.
closes COUCHDB-2943
PR: #654
PR-URL: https://github.com/apache/couchdb-fauxton/pull/654
Reviewed-By: Benjamin Keen <be...@gmail.com>
> Tray Refactor & Bugfix: does not close after querying
> -----------------------------------------------------
>
> Key: COUCHDB-2943
> URL: https://issues.apache.org/jira/browse/COUCHDB-2943
> Project: CouchDB
> Issue Type: Bug
> Components: Fauxton
> Reporter: Robert Kowalski
>
> When opening the Options Tray in the all_docs view, clicking query and then cancel, clicking Cancel in the Query Options panel doesn't close it.
> The root problem is the global event bus used by the parent Tray component which is registering the event listener two times.
> The Tray needs to use an Action and a Store and follow the Flux model instead of global events and event listeners in mount/unmount
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)