[GitHub] [nifi] joewitt commented on issue #3427: NIFI-6201 Suppressed stacktraces for expected error conditions (conne…

[GitBox <gi...@apache.org>]

joewitt commented on issue #3427: NIFI-6201 Suppressed stacktraces for expected error conditions (conne…
URL: https://github.com/apache/nifi/pull/3427#issuecomment-481755689
 
 
   What this PR aims to do is really good which is avoid an exception stack dump showing up for the user on a very expected/normal condition that when it happens we just want to tell the user "Hey the bundle you're trying to load isn't available".  We should definitely fix this.  Given that as implemented it is based on exception strings it could be brittle.  If the string changes this would break but breaking means it would just behave like it does today.  In that sense this PR as-is is probably +1-able since it does no harm but for the likely case will help.
   
   However, is there a non exception parsing path we can take here to get the details we want so this fix can be more permanent.  @bbende is this something you'll have time to consider soon?
   
   If not I'll merge this tomorrow assuming there are no strong disagreements.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services