You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/08/07 18:13:20 UTC
[commons-io] branch master updated (3d17107 -> bcb8a8c)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git.
from 3d17107 Try to issues on Windows and Java 15-ea.
new 14d9f7b Better test method name.
new bcb8a8c More assertions to validate test set ups.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/commons/io/FileUtilsTestCase.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
[commons-io] 01/02: Better test method name.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 14d9f7b0499db24b6f4c0c80e25a6be8fe2e63b3
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Aug 7 14:08:24 2020 -0400
Better test method name.
---
src/test/java/org/apache/commons/io/FileUtilsTestCase.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
index 8ae6ba3..4b35131 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
@@ -1154,7 +1154,7 @@ public class FileUtilsTestCase {
public void testCopyFile1() throws Exception {
final File destination = new File(temporaryFolder, "copy1.txt");
- backDateFile(testFile1); // set test file back 10 minutes
+ backDateFile10Minutes(testFile1); // set test file back 10 minutes
FileUtils.copyFile(testFile1, destination);
assertTrue(destination.exists(), "Check Exist");
@@ -1202,7 +1202,7 @@ public class FileUtilsTestCase {
public void testCopyFile2() throws Exception {
final File destination = new File(temporaryFolder, "copy2.txt");
- backDateFile(testFile1); // set test file back 10 minutes
+ backDateFile10Minutes(testFile1); // set test file back 10 minutes
FileUtils.copyFile(testFile1, destination);
assertTrue(destination.exists(), "Check Exist");
@@ -1228,7 +1228,7 @@ public class FileUtilsTestCase {
public void testCopyFile2WithoutFileDatePreservation() throws Exception {
final File destFile = new File(temporaryFolder, "copy2.txt");
- backDateFile(testFile1); // set test file back 10 minutes
+ backDateFile10Minutes(testFile1); // set test file back 10 minutes
// destination file time should not be less than this (allowing for granularity)
final long now = new Date().getTime() - 1000L;
@@ -3094,7 +3094,7 @@ public class FileUtilsTestCase {
}
}
- private void backDateFile(File testFile) throws IOException {
+ private void backDateFile10Minutes(File testFile) throws IOException {
final long mins10 = 1000 * 60 * 10;
final long lastModified1 = getLastModifiedMillis(testFile);
setLastModifiedMillis(testFile, lastModified1 - mins10);
[commons-io] 02/02: More assertions to validate test set ups.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit bcb8a8c20d66f4b9c0538e6e3069b08f2e65180a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Aug 7 14:13:07 2020 -0400
More assertions to validate test set ups.
---
src/test/java/org/apache/commons/io/FileUtilsTestCase.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
index 4b35131..ee14cbd 100644
--- a/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/io/FileUtilsTestCase.java
@@ -1400,9 +1400,9 @@ public class FileUtilsTestCase {
// Set dates in reverse order to avoid overwriting previous values
// Also, use full seconds (arguments are in ms) close to today
// but still highly unlikely to occur in the real world
- setLastModifiedMillis(sourceFile, DATE3);
- setLastModifiedMillis(sourceDirectory, DATE2);
- setLastModifiedMillis(source, DATE1);
+ assertTrue(setLastModifiedMillis(sourceFile, DATE3));
+ assertTrue(setLastModifiedMillis(sourceDirectory, DATE2));
+ assertTrue(setLastModifiedMillis(source, DATE1));
final File target = new File(temporaryFolder, "target");
final File targetDirectory = new File(target, "directory");
@@ -3097,7 +3097,7 @@ public class FileUtilsTestCase {
private void backDateFile10Minutes(File testFile) throws IOException {
final long mins10 = 1000 * 60 * 10;
final long lastModified1 = getLastModifiedMillis(testFile);
- setLastModifiedMillis(testFile, lastModified1 - mins10);
+ assertTrue(setLastModifiedMillis(testFile, lastModified1 - mins10));
// ensure it was changed
assertNotEquals(getLastModifiedMillis(testFile), lastModified1, "Should have changed source date");
}