You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/04/12 09:48:51 UTC

[GitHub] [netbeans] junichi11 opened a new pull request, #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

junichi11 opened a new pull request, #5813:
URL: https://github.com/apache/netbeans/pull/5813

   - Sometimes, we get the following log: Working directory: D:\a\netbeans\netbeans\php\php.editor\build\test\unit\work\o.n.m.p.e.c.P\testIssueGH5347_02
   - It is the working directory for a failed test
   
   https://github.com/apache/netbeans/blob/7f8dfdeb60ce3bec5554fc19ddb40fac0388d885/harness/nbjunit/src/org/netbeans/junit/NbTestCase.java#L524-L547
   
   https://github.com/apache/netbeans/blob/7f8dfdeb60ce3bec5554fc19ddb40fac0388d885/harness/nbjunit/src/org/netbeans/junit/NbTestCase.java#L472-L487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5813:
URL: https://github.com/apache/netbeans/pull/5813#issuecomment-1505493994

   @junichi11 sure this is fine with me. I noticed the failing PHP tests too. Thanks for looking into this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien merged pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5813:
URL: https://github.com/apache/netbeans/pull/5813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5813:
URL: https://github.com/apache/netbeans/pull/5813#issuecomment-1505491179

   > Wourn't an `assumeFalse(Utilities.isWindows());` be better as the first line of the test?
   
   @lkishalmi NbTestCase doesn't support assumptions unfortunately (I tried before), which is the super class for PHP tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5813:
URL: https://github.com/apache/netbeans/pull/5813#issuecomment-1505922333

   @mbien @lkishalmi Thank you for your reviews! Now, the master branch is green :) At least, the unit test passed in Linux. So, it should not be a big problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5813:
URL: https://github.com/apache/netbeans/pull/5813#issuecomment-1505690627

   going to merge this since it is difficult to stabilize master right now. We have 7+ restarts in some cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #5813: Disable PHPCCDocumentationTest.testIssueGH5347_02() in Windows

Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #5813:
URL: https://github.com/apache/netbeans/pull/5813#issuecomment-1504992936

   @mbien It seems that the above unit test fails sometimes with CI in Windows. We can see that the test throws an exception from the log. However, I'm not sure about the cause. So, I think that I'll disable the test in Windows. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists