You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/04/13 02:19:02 UTC
Change in asterixdb[cheshire-cat]: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026 )
Change subject: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
......................................................................
[NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
Change-Id: I0d8a8e2018a1839f20a7c1b601c26c8a3502ef5d
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
2 files changed, 30 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/11026/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
index 26f6524..1b216ea 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
@@ -79,6 +79,16 @@
}
@Override
+ public void sendRealTimeMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception {
+ ncs.sendRealTimeApplicationMessageToCC(ccId, JavaSerializationUtils.serialize(message), null);
+ }
+
+ @Override
+ public void sendRealTimeMessageToPrimaryCC(ICcAddressedMessage message) throws Exception {
+ sendRealTimeMessageToCC(ncs.getPrimaryCcId(), message);
+ }
+
+ @Override
public void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception {
IChannelControlBlock messagingChannel = ncs.getMessagingNetworkManager().getMessagingChannel(nodeId);
sendMessageToChannel(messagingChannel, message);
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
index 6bd58a9..88905fd 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
@@ -29,7 +29,7 @@
* @param message
* @throws Exception
*/
- public void sendMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
+ void sendMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
/**
* Sends application message from this NC to the CC.
@@ -37,7 +37,23 @@
* @param message
* @throws Exception
*/
- public void sendMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
+ void sendMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
+
+ /**
+ * Sends high-priority application message from this NC to the primary CC.
+ *
+ * @param message
+ * @throws Exception
+ */
+ void sendRealTimeMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
+
+ /**
+ * Sends high-priority application message from this NC to the CC.
+ *
+ * @param message
+ * @throws Exception
+ */
+ void sendRealTimeMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
/**
* Sends application message from this NC to another NC.
@@ -45,14 +61,14 @@
* @param message
* @throws Exception
*/
- public void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception;
+ void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception;
/**
* Queue a message to this {@link INCMessageBroker} for processing
*
* @param msg
*/
- public void queueReceivedMessage(INcAddressedMessage msg);
+ void queueReceivedMessage(INcAddressedMessage msg);
/**
* Creates and registers a Future for a message that will be send through this broker
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I0d8a8e2018a1839f20a7c1b601c26c8a3502ef5d
Gerrit-Change-Number: 11026
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange
Change in asterixdb[cheshire-cat]: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Till Westmann <ti...@apache.org>:
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026 )
Change subject: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I0d8a8e2018a1839f20a7c1b601c26c8a3502ef5d
Gerrit-Change-Number: 11026
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Tue, 13 Apr 2021 05:29:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[cheshire-cat]: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026 )
Change subject: [NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
......................................................................
[NO ISSUE][IPC] += sendRealTimeMessageTo[Primary]CC to INCMessageBroker
Change-Id: I0d8a8e2018a1839f20a7c1b601c26c8a3502ef5d
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
2 files changed, 30 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/26/11026/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
index 26f6524..1b216ea 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
@@ -79,6 +79,16 @@
}
@Override
+ public void sendRealTimeMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception {
+ ncs.sendRealTimeApplicationMessageToCC(ccId, JavaSerializationUtils.serialize(message), null);
+ }
+
+ @Override
+ public void sendRealTimeMessageToPrimaryCC(ICcAddressedMessage message) throws Exception {
+ sendRealTimeMessageToCC(ncs.getPrimaryCcId(), message);
+ }
+
+ @Override
public void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception {
IChannelControlBlock messagingChannel = ncs.getMessagingNetworkManager().getMessagingChannel(nodeId);
sendMessageToChannel(messagingChannel, message);
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
index 6bd58a9..88905fd 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
@@ -29,7 +29,7 @@
* @param message
* @throws Exception
*/
- public void sendMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
+ void sendMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
/**
* Sends application message from this NC to the CC.
@@ -37,7 +37,23 @@
* @param message
* @throws Exception
*/
- public void sendMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
+ void sendMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
+
+ /**
+ * Sends high-priority application message from this NC to the primary CC.
+ *
+ * @param message
+ * @throws Exception
+ */
+ void sendRealTimeMessageToPrimaryCC(ICcAddressedMessage message) throws Exception;
+
+ /**
+ * Sends high-priority application message from this NC to the CC.
+ *
+ * @param message
+ * @throws Exception
+ */
+ void sendRealTimeMessageToCC(CcId ccId, ICcAddressedMessage message) throws Exception;
/**
* Sends application message from this NC to another NC.
@@ -45,14 +61,14 @@
* @param message
* @throws Exception
*/
- public void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception;
+ void sendMessageToNC(String nodeId, INcAddressedMessage message) throws Exception;
/**
* Queue a message to this {@link INCMessageBroker} for processing
*
* @param msg
*/
- public void queueReceivedMessage(INcAddressedMessage msg);
+ void queueReceivedMessage(INcAddressedMessage msg);
/**
* Creates and registers a Future for a message that will be send through this broker
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11026
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I0d8a8e2018a1839f20a7c1b601c26c8a3502ef5d
Gerrit-Change-Number: 11026
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange