You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/23 08:03:38 UTC

[GitHub] [airflow] yuqian90 commented on a change in pull request #7470: [AIRFLOW-6834] Fix some flaky tests in test_scheduler_job.py

yuqian90 commented on a change in pull request #7470: [AIRFLOW-6834] Fix some flaky tests in test_scheduler_job.py
URL: https://github.com/apache/airflow/pull/7470#discussion_r382974156
 
 

 ##########
 File path: airflow/cli/commands/task_command.py
 ##########
 @@ -158,33 +158,32 @@ def task_run(args, dag=None):
     # behind multiple open sleeping connections while heartbeating, which could
     # easily exceed the database connection limit when
     # processing hundreds of simultaneous tasks.
-    settings.configure_orm(disable_connection_pool=True)
 
 Review comment:
   This change is needed because I realized test_task_commands sometimes interferes with other tests because this line sets `disable_connection_pool` to True without setting it back. So when test_task_commands run first, connection pool is disabled globally and never restored.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services