You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2025/10/17 12:45:42 UTC
[PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
airborne12 opened a new pull request, #57115:
URL: https://github.com/apache/doris/pull/57115
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3415450100
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3415643726
<details>
<summary>TPC-DS: <b>Total hot run time: 190080 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 62156fd3f9bc26c6795d2d9ab504fdd81a3c8707, data reload: false
query1 1045 451 412 412
query2 6576 1756 1711 1711
query3 6769 232 220 220
query4 26466 23831 23277 23277
query5 5149 690 509 509
query6 351 267 230 230
query7 4660 502 311 311
query8 316 279 263 263
query9 8739 2572 2533 2533
query10 561 352 296 296
query11 15557 15091 14858 14858
query12 190 117 110 110
query13 1672 564 440 440
query14 11684 9351 9372 9351
query15 227 199 182 182
query16 7870 701 609 609
query17 1927 851 654 654
query18 2225 482 347 347
query19 240 221 191 191
query20 146 132 139 132
query21 217 136 117 117
query22 4403 4719 4549 4549
query23 34755 33849 33814 33814
query24 8992 2585 2607 2585
query25 655 576 510 510
query26 1630 297 169 169
query27 2718 538 389 389
query28 4360 2223 2208 2208
query29 821 708 574 574
query30 311 225 219 219
query31 931 804 723 723
query32 87 77 76 76
query33 608 389 400 389
query34 808 838 516 516
query35 826 826 728 728
query36 967 955 916 916
query37 127 121 89 89
query38 3527 3605 3458 3458
query39 1474 1403 1417 1403
query40 232 128 118 118
query41 58 58 57 57
query42 119 110 122 110
query43 496 514 462 462
query44 1346 820 814 814
query45 182 178 169 169
query46 868 996 635 635
query47 1726 1780 1693 1693
query48 401 427 333 333
query49 774 528 406 406
query50 692 694 412 412
query51 3917 3896 3915 3896
query52 115 118 105 105
query53 244 275 195 195
query54 608 605 521 521
query55 85 85 87 85
query56 328 314 308 308
query57 1152 1164 1101 1101
query58 298 277 270 270
query59 2543 2680 2592 2592
query60 343 341 327 327
query61 159 157 153 153
query62 806 729 688 688
query63 232 203 189 189
query64 4429 1150 831 831
query65 4033 3965 3977 3965
query66 1078 439 329 329
query67 15477 15106 14971 14971
query68 9445 985 593 593
query69 496 333 289 289
query70 1356 1259 1256 1256
query71 506 352 340 340
query72 5918 5065 4813 4813
query73 719 577 366 366
query74 9206 8791 8894 8791
query75 4254 3368 2854 2854
query76 3778 1189 756 756
query77 922 409 320 320
query78 9490 9791 8918 8918
query79 4595 841 568 568
query80 717 560 521 521
query81 492 262 228 228
query82 286 159 131 131
query83 319 272 250 250
query84 295 117 90 90
query85 856 475 469 469
query86 341 327 304 304
query87 3771 3754 3549 3549
query88 2883 2256 2223 2223
query89 437 336 322 322
query90 2129 219 205 205
query91 160 160 134 134
query92 86 69 66 66
query93 2409 1001 637 637
query94 680 448 329 329
query95 403 322 313 313
query96 494 580 282 282
query97 2900 2976 2878 2878
query98 235 223 214 214
query99 1444 1410 1268 1268
Total cold run time: 285350 ms
Total hot run time: 190080 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3417879107
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3415454082
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3415665235
<details>
<summary>ClickBench: <b>Total hot run time: 30.73 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 62156fd3f9bc26c6795d2d9ab504fdd81a3c8707, data reload: false
query1 0.06 0.06 0.05
query2 0.10 0.06 0.06
query3 0.26 0.09 0.08
query4 1.61 0.12 0.11
query5 0.29 0.27 0.26
query6 1.17 0.67 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.63 0.53 0.51
query10 0.59 0.59 0.59
query11 0.17 0.11 0.12
query12 0.15 0.12 0.12
query13 0.63 0.63 0.61
query14 1.03 1.02 1.04
query15 0.87 0.86 0.88
query16 0.43 0.40 0.39
query17 1.05 1.07 1.10
query18 0.21 0.20 0.20
query19 1.91 1.78 1.82
query20 0.02 0.01 0.01
query21 15.43 0.94 0.57
query22 0.76 1.11 0.70
query23 15.03 1.41 0.68
query24 7.13 1.69 0.97
query25 0.49 0.18 0.17
query26 0.64 0.16 0.14
query27 0.06 0.05 0.06
query28 10.25 1.35 0.92
query29 12.57 3.91 3.24
query30 0.28 0.15 0.11
query31 2.82 0.59 0.41
query32 3.23 0.56 0.48
query33 3.09 3.10 3.17
query34 16.16 5.49 4.85
query35 4.90 4.93 4.92
query36 0.70 0.53 0.51
query37 0.10 0.08 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.17 0.14
query41 0.09 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 105.38 s
Total hot run time: 30.73 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #57115:
URL: https://github.com/apache/doris/pull/57115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3415743930
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62156fd3f9bc26c6795d2d9ab504fdd81a3c8707_62156fd3f9bc26c6795d2d9ab504fdd81a3c8707/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62156fd3f9bc26c6795d2d9ab504fdd81a3c8707_62156fd3f9bc26c6795d2d9ab504fdd81a3c8707/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.54% (17832/33940) |
| Line Coverage | 37.80% (161932/428393) |
| Region Coverage | 32.22% (123488/383286) |
| Branch Coverage | 33.64% (54145/160936) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3416073543
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57115_62156fd3f9bc26c6795d2d9ab504fdd81a3c8707_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57115_62156fd3f9bc26c6795d2d9ab504fdd81a3c8707_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.22% (23701/33279) |
| Line Coverage | 57.60% (246630/428151) |
| Region Coverage | 52.51% (203886/388250) |
| Branch Coverage | 54.38% (88011/161831) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](inverted index) remove duplicate code in comparison evaluate index [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57115:
URL: https://github.com/apache/doris/pull/57115#issuecomment-3417879061
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org