You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:00:13 UTC
[GitHub] [superset] eriendeng opened a new issue, #20667: Show comment for ColumnElement/TableElement
eriendeng opened a new issue, #20667:
URL: https://github.com/apache/superset/issues/20667
1. I notice that common db_engine_spec has function `get_table_comment`, so it's easy to get comment in api `superset/views/core.py::tables()` and it could be filterable in frontend.
2. similar to point 1, I think `ColumnElement` is able to do the same thing, and maybe it could be a tooltip to show column comment or sth else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show comment for ColumnElement/TableElement [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #20667: Show comment for ColumnElement/TableElement
URL: https://github.com/apache/superset/issues/20667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kevinmarsh commented on issue #20667: Show comment for ColumnElement/TableElement
Posted by GitBox <gi...@apache.org>.
kevinmarsh commented on issue #20667:
URL: https://github.com/apache/superset/issues/20667#issuecomment-1396108798
So pulling an [example from the Django docs](https://docs.djangoproject.com/en/4.2/ref/models/fields/#enumeration-types):
```python
class Card(models.Model):
class Suit(models.IntegerChoices):
DIAMOND = 1
SPADE = 2
HEART = 3
CLUB = 4
suit = models.IntegerField(choices=Suit.choices)
```
The `suit` column is stored as an integer from `1`-`4` however you lose the context of what those integers represent when viewing the data in Superset.
---
[Starting in Django 4.2](https://docs.djangoproject.com/en/dev/releases/4.2/#comments-on-columns-and-tables), you can provide both table and column comments which would be really valuable to expose in this view as a comment or tooltip
```diff
suit = models.IntegerField(
choices=Suit.choices,
+ db_comment="1 represents 'Diamond', 2 represents 'Spade', etc."
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Show comment for ColumnElement/TableElement [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20667:
URL: https://github.com/apache/superset/issues/20667#issuecomment-1946854611
Closing this as stale since it's been silent for so long, it's unclear if it's a bug _per se_, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org