You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by majetideepak <gi...@git.apache.org> on 2017/12/21 12:45:24 UTC

[GitHub] orc pull request #204: ORC-283: Enable the cmake build to pick specified lib...

GitHub user majetideepak opened a pull request:

    https://github.com/apache/orc/pull/204

    ORC-283: Enable the cmake build to pick specified libraries over the …

    …default libraries

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/majetideepak/orc ORC-283

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit 1a34380e7eb6323e3f0b92b377943f1ba5562d5e
Author: Deepak Majeti <md...@...>
Date:   2017-12-21T12:17:12Z

    ORC-283: Enable the cmake build to pick specified libraries over the default libraries

----


---

[GitHub] orc pull request #204: ORC-283: Enable the cmake build to pick specified pat...

Posted by majetideepak <gi...@git.apache.org>.

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/204#discussion_r158269151
  
    --- Diff: cmake_modules/FindGTest.cmake ---
    @@ -28,7 +28,7 @@ find_path (GTEST_INCLUDE_DIR gmock/gmock.h HINTS
       NO_DEFAULT_PATH
       PATH_SUFFIXES "include")
     
    -find_library (GTEST_LIBRARIES NAMES gmock PATHS
    +find_library (GTEST_LIBRARIES NAMES gmock HINTS
    --- End diff --
    
    `HINTS` is apt here. `PATHS` must only be used for hardcoded guesses.
    https://cmake.org/cmake/help/v3.0/command/find_library.html


---

[GitHub] orc pull request #204: ORC-283: Enable the cmake build to pick specified pat...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/204


---