You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/08 01:38:56 UTC

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17284: [improve][doc] add developers-landing page

Anonymitaet commented on code in PR #17284:
URL: https://github.com/apache/pulsar/pull/17284#discussion_r965425149


##########
site2/docs/getting-started-standalone.md:
##########
@@ -104,34 +104,34 @@ bin/pulsar-client consume my-topic -s 'my-subscription' -p Earliest -n 0
 
 Earliest means consuming from the earliest **unconsumed** message. `-n` configures the number of messages to consume, 0 means to consume forever.
 
-As before, this is useful for trialling things on the command line, but in practice you'll use the Consumer API in your application code, or Pulsar IO connectors for reading data from Pulsar to push to other systems.
+As before, this is useful for experimenting with messages, but in practice you'll use the Consumer API in your application code, or Pulsar IO connectors for reading data from Pulsar to push to other systems.
 
-You'll see the messages that you produce in the previous step:
+You'll see the messages you produce in the previous step:
 
 ```text
 ----- got message -----
 key:[null], properties:[], content:Hello Pulsar!
 ```
 
-## Step 6. Write some more messages
+## Write some more messages
 
 Leave the consume command from the previous step running. If you've already closed it, just re-run it.
 
-Now open a new terminal window and produce more messages, the default message separator is `,`:
+Now open a new terminal window and produce more messages. The default message separator is `,`:
 
 ```bash
 bin/pulsar-client produce my-topic --messages "$(seq -s, -f 'Message NO.%g' -t '\n' 1 10)"
 ```
 
 Note how they are displayed almost instantaneously in the consumer terminal.
 
-## Step 7. Stop the Pulsar cluster
+## Stop the Pulsar cluster
 
 Once you've finished you can shut down the Pulsar cluster. Press **Ctrl-C** in the terminal window in which you started the cluster.
 
-## Further readings
+## Related Topics

Review Comment:
   ```suggestion
   ## Related topics
   ```
   
   Keep consistent for headings (sentence style)



##########
site2/docs/getting-started-standalone.md:
##########
@@ -16,7 +16,7 @@ If you're looking to run a full production Pulsar installation, see the [Deployi
 
 - JRE (64-bit). Different Pulsar versions rely on different JRE versions. For how to choose the JRE version, see [Pulsar Runtime Java Version Recommendation](https://github.com/apache/pulsar/blob/master/README.md#pulsar-runtime-java-version-recommendation).
 
-## Step 1. Download Pulsar distribution
+## Download Pulsar distribution

Review Comment:
   Why remove "Step"? Comments see https://github.com/apache/pulsar/pull/17475#discussion_r963198907
   
   This is what we look like:
   <img width="1837" alt="image" src="https://user-images.githubusercontent.com/50226895/189014101-2249f20e-7dc5-463c-9a8e-e2a7ee5fb434.png">
   
   Other examples:
   https://kafka.apache.org/quickstart
   <img width="975" alt="image" src="https://user-images.githubusercontent.com/50226895/189014195-44e160ff-9884-434e-a754-67e540fea947.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org