[GitHub] [accumulo] ctubbsii commented on issue #1808: LoggingRunnable causes servers to happily ignore catastrophic failures

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #1808:
URL: https://github.com/apache/accumulo/issues/1808#issuecomment-733839847


   > I wonder if this is related to - or just similar behavior to ...
   
   @EdColeman I was thinking the same things. It's certainly similar in nature. This catching of Throwable, and/or not setting UncaughtExceptionHandlers on threads we spin off is really likely to bite us. It'd be great if we could take a comprehensive look at 1) all occurrences of us catching Throwable to verify their correctness, and 2) check all thread management code to ensure we properly handle uncaught exceptions.; The main problem is there's a *lot* (of both) of those. This issue is a specific find that was directly observed to be problematic (luckily, it occurred during testing and not on a production system), that can be fixed in a targeted way, regardless of whether we get a chance to do the comprehensive look at the rest.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org