You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 20:12:16 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #12320: ARROW-15483: [Release] Revamp the verification scripts

kszucs commented on a change in pull request #12320:
URL: https://github.com/apache/arrow/pull/12320#discussion_r806201821



##########
File path: cpp/CMakeLists.txt
##########
@@ -123,6 +123,7 @@ list(GET ARROW_LLVM_VERSIONS 0 ARROW_LLVM_VERSION_PRIMARY)
 string(REGEX REPLACE "^([0-9]+)(\\..+)?" "\\1" ARROW_LLVM_VERSION_PRIMARY_MAJOR
                      "${ARROW_LLVM_VERSION_PRIMARY}")
 
+# TODO(kszucs): should definitely remove this

Review comment:
       `.env` is used for docker-compose and we shouldn't depend on it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org