You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by mkby <gi...@git.apache.org> on 2017/04/11 10:01:31 UTC
[GitHub] incubator-trafodion pull request #1061: [TRAFODION-2588] monitor failed to s...
GitHub user mkby opened a pull request:
https://github.com/apache/incubator-trafodion/pull/1061
[TRAFODION-2588] monitor failed to start if part of zookeeper server is down
retry 3 times when connecting to zookeeper.
@narendragoyal @zcorrea please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkby/incubator-trafodion 2588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/1061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1061
----
commit 18ad65a99275b44a3f68db01ca5385665a2e5195
Author: Eason <hf...@gmail.com>
Date: 2017-04-11T09:58:32Z
[TRAFODION-2588] monitor failed to start if part of zookeeper server is down
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1061: [TRAFODION-2588] monitor failed to s...
Posted by venkat1m <gi...@git.apache.org>.
Github user venkat1m commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1061#discussion_r111296731
--- Diff: core/sqf/monitor/linux/zclient.cxx ---
@@ -53,6 +53,9 @@
// The monitors register their znodes under the cluster znode
#define ZCLIENT_CLUSTER_ZNODE "/cluster"
+// zookeeper connection retry count
+#define ZOOKEEPER_RETRY_COUNT 3
--- End diff --
Wouldn't it be better to make this an environment variable or monitor config setting that can be changed instead of a hardcoded retry count of 3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1061: [TRAFODION-2588] monitor failed to s...
Posted by mkby <gi...@git.apache.org>.
Github user mkby commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/1061#discussion_r111298734
--- Diff: core/sqf/monitor/linux/zclient.cxx ---
@@ -53,6 +53,9 @@
// The monitors register their znodes under the cluster znode
#define ZCLIENT_CLUSTER_ZNODE "/cluster"
+// zookeeper connection retry count
+#define ZOOKEEPER_RETRY_COUNT 3
--- End diff --
Based on the test result, actually retry for once is enough for this case. So it's not quite necessary to modify this value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request #1061: [TRAFODION-2588] monitor failed to s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/1061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---