[GitHub] [sling-org-apache-sling-bundleresource-impl] michalcukierman commented on a diff in pull request #1: SLING-11504 BundleResource/JcrNodeResource getResourceType fallback consistency

[GitBox <gi...@apache.org>]

michalcukierman commented on code in PR #1:
URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r944198717


##########
src/test/java/org/apache/sling/bundleresource/impl/BundleResourceTest.java:
##########
@@ -111,7 +111,7 @@ void addContent(BundleResourceCache cache, String path, String content) throws I
         assertEquals(JcrConstants.NT_FILE, rsrc.getResourceType());
         assertNull(rsrc.getResourceSuperType());
         final ValueMap vm = rsrc.getValueMap();
-        assertEquals(JcrConstants.NT_FILE, vm.get(ResourceResolver.PROPERTY_RESOURCE_TYPE, String.class));
+        assertNull(vm.get(ResourceResolver.PROPERTY_RESOURCE_TYPE, String.class));
         assertEquals("foo", vm.get("test", String.class));

Review Comment:
   Tests added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org