You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/06/16 15:30:48 UTC
[GitHub] storm pull request #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
GitHub user darionyaphet opened a pull request:
https://github.com/apache/storm/pull/1493
[STORM-1908] Support Storm HBase ZooKeeper Config
[STORM-1908](https://issues.apache.org/jira/browse/STORM-1908)
Support Storm HBase ZooKeeper Config . About ZooKeeper host , port and parent .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darionyaphet/storm STORM-1908
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1493
----
commit bd2ede7e87a7540ce609c9e925091c4e6cf90d06
Author: darionyaphet <da...@gmail.com>
Date: 2016-06-16T15:29:27Z
STORM-1908 : Support Storm HBase ZooKeeper Config
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1493
Since we override all options being provided from HBase config, these three parameters can be fed as well. I think just removing TODO would be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet closed the pull request at:
https://github.com/apache/storm/pull/1493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1493
@darionyaphet
I mean we already support the thing what TODO describes.
Please refer https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java#L66-L68
So this issue is invalid, and TODO can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1493
@HeartSaVioR I got we can set config using `Config` and don't have to support new API ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1493
@HeartSaVioR Yes I know . Because Zookeeper properties is very useful , so I wish to open a new API to support it :) . If you think it's unnecessarily , I will close this PR .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1493
@darionyaphet
You can set properties which we can pass to hbase-*.xml into Storm configuration Map (under specific key for hbase), and storm-hbase merges (override) that configuration with default HBase configuration which reads hbase-*.xml to initialize. So passing them to Storm configuration Map before submitting topology would be sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by HariSekhon <gi...@git.apache.org>.
Github user HariSekhon commented on the issue:
https://github.com/apache/storm/pull/1493
@darionyaphet wrong @ person?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1493
@HariSekhon Yep So sorry ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1493
@HeartSaVioR OK Close it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1493
@HariSekhon what you mean is should remove `TODO` when all HBase options have provided ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1493: [STORM-1908] Support Storm HBase ZooKeeper Config
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1493
@darionyaphet Let's close for now. We can enrich description to README how to pass ZK properties when we think it would be better to guide passing ZK properties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---