You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/17 15:52:15 UTC
[GitHub] [tvm] u99127 opened a new pull request #7122: Add ACL testing to the CI for AArch64.
u99127 opened a new pull request #7122:
URL: https://github.com/apache/tvm/pull/7122
Add testing for ACL to the CI for AArch64. A PR follows
to add this to the Jenkinsfile once the docker changes land.
We also need a separate script to run the tests as the full
python integration tests are currently broken.
[I've tried this on an AArch64 Linux machine and it appears to
work ok.]
I think we'll need to bake a new docker image before the
jenkins file changes land.
@zhiics @comaniac @lhutton1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747688337
> LGTM to the dockerfile and build config. I expect the follow-up PR would also enable `USE_ARM_COMPUTE_LIB_GRAPH_RUNTIME` to cover ACL runtime unit tests.
>
That is the next step once this is working .Turning that on probably also needs a bit of tweaking in the infra for the tests which I'll try and fix up next. The idea was to get the docker changes in and the testing on par with what happens with the other pipeline but natively.
> On the other hand, I don't think we need to add a new task script for ACL. The current Jenkinsfile already covers the ACL unit test in L280 (currently comment out). Specifically, `task_python_integration.sh` covers all the unit tests under `tests/python/contrib`, including ACL tests. As a result, I would prefer to bring L280 back in the Jenkinsfile to enable all the tests.
>
As I indicated in the covering letter, turning on task_python_integration.sh was failing in my test run with failures with tolerances that I suspect will need more time than I have this side of the holidays.
> Note: Docker image has to be updated after this PR. cc @tqchen
regards
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747703831
>
> > As I indicated in the covering letter, turning on task_python_integration.sh was failing in my test run with failures with tolerances that I suspect will need more time than I have this side of the holidays. It also means we can get quicker to first getting ACL runtime tests in the CI first.
>
> I must be missing the description before. Then it makes sense to me to have a separate script first until `task_python_integration.sh` fully works on AArch64 platform.
Thanks for the swift review. Yes , sorry I don't think I was explicit enough in saying that.
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747698590
> That is the next step once this is working .Turning that on probably also needs a bit of tweaking in the infra for the tests which I'll try and fix up next. The idea was to get the docker changes in and the testing on par with what happens with the other pipeline but natively.
I see. Thanks for the clarification.
> As I indicated in the covering letter, turning on task_python_integration.sh was failing in my test run with failures with tolerances that I suspect will need more time than I have this side of the holidays. It also means we can get quicker to first getting ACL runtime tests in the CI first.
I must be missing the description before. Then it makes sense to me to have a separate script first until `task_python_integration.sh` fully works on AArch64 platform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-785453479
Need a docker image update for ci_arm - @tqchen @zhiics , could this be done please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 edited a comment on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
u99127 edited a comment on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747688337
> LGTM to the dockerfile and build config. I expect the follow-up PR would also enable `USE_ARM_COMPUTE_LIB_GRAPH_RUNTIME` to cover ACL runtime unit tests.
>
That is the next step once this is working .Turning that on probably also needs a bit of tweaking in the infra for the tests which I'll try and fix up next. The idea was to get the docker changes in and the testing on par with what happens with the other pipeline but natively.
> On the other hand, I don't think we need to add a new task script for ACL. The current Jenkinsfile already covers the ACL unit test in L280 (currently comment out). Specifically, `task_python_integration.sh` covers all the unit tests under `tests/python/contrib`, including ACL tests. As a result, I would prefer to bring L280 back in the Jenkinsfile to enable all the tests.
>
As I indicated in the covering letter, turning on task_python_integration.sh was failing in my test run with failures with tolerances that I suspect will need more time than I have this side of the holidays. It also means we can get quicker to first getting ACL runtime tests in the CI first.
> Note: Docker image has to be updated after this PR. cc @tqchen
regards
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747811368
Thanks @u99127 @zhiics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7122: [CI] Add ACL to the CI for AArch64
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7122:
URL: https://github.com/apache/tvm/pull/7122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org