[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2054: [KYUUBI-1819] Support closing Flink SQL engine process

[GitBox <gi...@apache.org>]

pan3793 commented on a change in pull request #2054:
URL: https://github.com/apache/incubator-kyuubi/pull/2054#discussion_r820571968



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala
##########
@@ -28,4 +28,24 @@ class FlinkProcessBuilderSuite extends KyuubiFunSuite {
     val commands = builder.toString.split(' ')
     assert(commands.exists(_ endsWith "flink-sql-engine.sh"))
   }
+
+  test("kill application") {
+    val processBuilder = new FakeFlinkProcessBuilder(conf) {
+      override protected def env: Map[String, String] = Map("FLINK_HOME" -> "")
+    }
+    val exit1 = processBuilder.killApplication("""
+      [INFO] SQL update statement has been successfully submitted to the cluster:
+      Job ID: 6b1af540c0c0bb3fcfcad50ac037c862

Review comment:
       what's the magic code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org