You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/24 13:04:00 UTC
[jira] [Commented] (FLINK-9213) Revert breaking change in
checkpoint detail URL
[ https://issues.apache.org/jira/browse/FLINK-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449806#comment-16449806 ]
ASF GitHub Bot commented on FLINK-9213:
---------------------------------------
GitHub user azagrebin opened a pull request:
https://github.com/apache/flink/pull/5906
[FLINK-9213] [REST] [docs] Revert checkpoint details URL from '/jobs/:jobid/checkpoints/:checkpointid' to '/jobs/:jobid/checkpoints/details/:checkpointid' as it was in 1.5
## What is the purpose of the change
This PR aligns the newer 1.5 REST implementation of getting checkpoint details with previous legacy one by reverting URL address
from `/jobs/:jobid/checkpoints/:checkpointid`
to `/jobs/:jobid/checkpoints/details/:checkpointid`
## Brief change log
- revert `URL` static field in `CheckpointStatisticDetailsHeaders`
- regenerate docs for `docs/_includes/generated/rest_dispatcher.html`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/azagrebin/flink FLINK-9213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5906.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5906
----
commit 4ebe10873bcc784f626a35bf6055d93f39e6b9af
Author: Andrey Zagrebin <an...@...>
Date: 2018-04-24T11:26:40Z
[FLINK-9213] Revert checkpoint details URL from '/jobs/:jobid/checkpoints/:checkpointid' to '/jobs/:jobid/checkpoints/details/:checkpointid' as it was in 1.5
----
> Revert breaking change in checkpoint detail URL
> -----------------------------------------------
>
> Key: FLINK-9213
> URL: https://issues.apache.org/jira/browse/FLINK-9213
> Project: Flink
> Issue Type: Bug
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Fix For: 1.5.0
>
>
> In 1.4, the URL for retrieving detailed checkpoint information is {{/jobs/:jobid/checkpoints/details/:checkpointid}}, whereas in 1.5 it is {{/jobs/:jobid/checkpoints/:checkpointid}}.
> This is a breaking change that also affects the WebUI and should thus be reverted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)