[GitHub] [pinot] navina commented on a diff in pull request #11110: Add stat to track number of segments that have valid doc id snapshots

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #11110:
URL: https://github.com/apache/pinot/pull/11110#discussion_r1264225009


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -540,6 +540,8 @@ protected void doTakeSnapshot() {
       }
     }
 
+    _serverMetrics.setValueOfTableGauge(_tableNameWithType, ServerGauge.UPSERT_VALID_DOC_ID_SNAPSHOT_COUNT,

Review Comment:
   Dumb question: how is this metric going to be used? like what does it tell us?
   
   Why is this metric defined at table level rather than a partition level ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org