[Impala-ASF-CR] IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int)

["Qifan Chen (Code Review)" <ge...@cloudera.org>]

Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17610 )

Change subject: IMPALA-9338 Fix impala crashing in impala::RowDescriptor::TupleIsNullable(int)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17610/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java
File fe/src/main/java/org/apache/impala/planner/PlanNode.java:

http://gerrit.cloudera.org:8080/#/c/17610/1/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1026
PS1, Line 1026: toLowerCase()
If SQL identifiers (such as column names) are involved during comparison, I think we need to distinguish regular identifiers, such as INT_col or int_col which are case insensitive, from delimitated identifiers, such as "INT_col" or "int_col" which are case sensitive.  In the example, INT_COL is equal to int_col. But "INT_col" is not equal to "int_col".



-- 
To view, visit http://gerrit.cloudera.org:8080/17610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ba031d7a6eda21a77b0e53bc41772ee9e00a528
Gerrit-Change-Number: 17610
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Jul 2021 17:04:26 +0000
Gerrit-HasComments: Yes