[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22835: feat: Enable new dataset creation flow II

["lyndsiWilliams (via GitHub)" <gi...@apache.org>]

lyndsiWilliams commented on code in PR #22835:
URL: https://github.com/apache/superset/pull/22835#discussion_r1092554581


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx:
##########
@@ -104,13 +100,13 @@ function Footer({
         if (typeof response === 'number') {
           logEvent(LOG_ACTIONS_DATASET_CREATION_SUCCESS, datasetObject);
           // When a dataset is created the response we get is its ID number
-          goToPreviousUrl();
+          history.push(`/chart/add/?dataset=${datasetObject.table_name}`);
         }
       });
     }
   };
 
-  const CREATE_DATASET_TEXT = t('Create Dataset');
+  const CREATE_DATASET_TEXT = t('Create Dataset and Create Chart');

Review Comment:
   Good thinking on the text, and good catch on the tooltip in the footer! Fixed in [`this commit`](https://github.com/apache/superset/pull/22835/commits/76b3590962bea5fd457cb8bf790ad811d147c316).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org