You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/05 23:38:48 UTC
[kudu-CR] raft consensus-itest: address flakiness in config-change tests
Hello Dan Burkert, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4637
to review the following change.
Change subject: raft_consensus-itest: address flakiness in config-change tests
......................................................................
raft_consensus-itest: address flakiness in config-change tests
Several tests were waiting until all replicas had set their
LAST_RECEIVED operation to '1' and assuming that a config change could
then proceed. However, even if all servers have received index 1, this
doesn't necessarily mean that the leader has received the corresponding
acknowledgement, and thus the leader may refuse the config change.
Change-Id: I3eed4ca551a3342dcb07330c43ef94e169db7ab8
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4637/1
--
To view, visit http://gerrit.cloudera.org:8080/4637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eed4ca551a3342dcb07330c43ef94e169db7ab8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] raft consensus-itest: address flakiness in config-change tests
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: raft_consensus-itest: address flakiness in config-change tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eed4ca551a3342dcb07330c43ef94e169db7ab8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] raft consensus-itest: address flakiness in config-change tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: raft_consensus-itest: address flakiness in config-change tests
......................................................................
raft_consensus-itest: address flakiness in config-change tests
Several tests were waiting until all replicas had set their
LAST_RECEIVED operation to '1' and assuming that a config change could
then proceed. However, even if all servers have received index 1, this
doesn't necessarily mean that the leader has received the corresponding
acknowledgement, and thus the leader may refuse the config change.
Change-Id: I3eed4ca551a3342dcb07330c43ef94e169db7ab8
Reviewed-on: http://gerrit.cloudera.org:8080/4637
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eed4ca551a3342dcb07330c43ef94e169db7ab8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>