You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/06/01 08:38:01 UTC

[Impala-ASF-CR] IMPALA-9410: Support resolving ORC file columns by names

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 )

Change subject: IMPALA-9410: Support resolving ORC file columns by names
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.h
File be/src/exec/orc-metadata-utils.h:

http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.h@109
PS6, Line 109: std::string
> could be const&
This is still unresolved.



-- 
To view, visit http://gerrit.cloudera.org:8080/18397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29562a059160c19eb58ccea76aa959d2e408f8de
Gerrit-Change-Number: 18397
Gerrit-PatchSet: 6
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Jun 2022 08:38:01 +0000
Gerrit-HasComments: Yes