You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/12 08:18:23 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10294: ARROW-12736: [C++] Eliminate forced copy of potentially large vector>

pitrou commented on a change in pull request #10294:
URL: https://github.com/apache/arrow/pull/10294#discussion_r630825994



##########
File path: cpp/src/arrow/record_batch.h
##########
@@ -108,7 +108,7 @@ class ARROW_EXPORT RecordBatch {
   virtual std::shared_ptr<ArrayData> column_data(int i) const = 0;
 
   /// \brief Retrieve all arrays' internal data from the record batch.
-  virtual ArrayDataVector column_data() const = 0;
+  virtual const ArrayDataVector& column_data() const = 0;

Review comment:
       Should we do the same transformation for `columns()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org