You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by ma...@apache.org on 2025/01/08 03:33:19 UTC
(cloudberry) 14/16: change IC_PROXY_INVALID_CONTENT to int16 (#15219)
This is an automated email from the ASF dual-hosted git repository.
maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 1e2d348e9374ba78855a33ac55e62cb60c0b84c7
Author: Hongxu Ma <in...@outlook.com>
AuthorDate: Mon Mar 20 14:49:56 2023 +0800
change IC_PROXY_INVALID_CONTENT to int16 (#15219)
PR #15139 introduced a compilation warning:
```
ic_proxy_peer.c:159:17: warning: result of comparison of constant 65534 with expression of type 'int16' (aka 'short') is always false [-Wtautological-constant-out-of-range-compare]
peer->content == IC_PROXY_INVALID_CONTENT)
~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
This PR fix it: change IC_PROXY_INVALID_CONTENT to int16 (align its type to ICProxyPeer.content field).
---
contrib/interconnect/proxy/ic_proxy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/interconnect/proxy/ic_proxy.h b/contrib/interconnect/proxy/ic_proxy.h
index 4935bee1a0..7cd54508d2 100644
--- a/contrib/interconnect/proxy/ic_proxy.h
+++ b/contrib/interconnect/proxy/ic_proxy.h
@@ -20,7 +20,7 @@
#include "postmaster/postmaster.h"
#define IC_PROXY_BACKLOG 1024
-#define IC_PROXY_INVALID_CONTENT ((uint16) -2)
+#define IC_PROXY_INVALID_CONTENT ((int16) -2)
#define IC_PROXY_INVALID_DBID ((int16) 0)
/* pause the sender when the unack packet increase to this threshold */
#define IC_PROXY_TRESHOLD_UNACK_PACKET_PAUSE 100
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org