You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@creadur.apache.org by po...@apache.org on 2020/02/01 16:14:39 UTC

[creadur-rat] branch master updated: RAT-266: Add .factorypath to Eclipse default excludes

This is an automated email from the ASF dual-hosted git repository.

pottlinger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/creadur-rat.git


The following commit(s) were added to refs/heads/master by this push:
     new bcaff1e  RAT-266: Add .factorypath to Eclipse default excludes
     new 67c1743  Merge pull request #17 from michael-o/RAT-266
bcaff1e is described below

commit bcaff1efdbb942c1b69e2b930dad489d65fd53e8
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sat Feb 1 16:51:03 2020 +0100

    RAT-266: Add .factorypath to Eclipse default excludes
    
    This closes #12
---
 .../src/main/java/org/apache/rat/mp/util/ExclusionHelper.java       | 4 +++-
 .../src/test/java/org/apache/rat/mp/util/ExclusionHelperTest.java   | 6 +++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java b/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java
index 98c637c..9552cc5 100644
--- a/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java
+++ b/apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ExclusionHelper.java
@@ -50,8 +50,10 @@ public final class ExclusionHelper {
      * The Eclipse specific default excludes.
      */
     static final List<String> ECLIPSE_DEFAULT_EXCLUDES = Collections
-            .unmodifiableList(Arrays.asList(".checkstyle",
+            .unmodifiableList(Arrays.asList(
+                    ".checkstyle",//
                     ".classpath",//
+                    ".factorypath",//
                     ".project", //
                     ".settings/**/*"));
 
diff --git a/apache-rat-plugin/src/test/java/org/apache/rat/mp/util/ExclusionHelperTest.java b/apache-rat-plugin/src/test/java/org/apache/rat/mp/util/ExclusionHelperTest.java
index 2d6f965..bb7c32c 100644
--- a/apache-rat-plugin/src/test/java/org/apache/rat/mp/util/ExclusionHelperTest.java
+++ b/apache-rat-plugin/src/test/java/org/apache/rat/mp/util/ExclusionHelperTest.java
@@ -45,7 +45,7 @@ public class ExclusionHelperTest {
 
     @Test
     public void testNumberOfExclusions() {
-        assertEquals("Did you change the number of eclipse excludes?", 4,
+        assertEquals("Did you change the number of eclipse excludes?", 5,
                 ECLIPSE_DEFAULT_EXCLUDES.size());
         assertEquals("Did you change the number of idea excludes?", 4,
                 IDEA_DEFAULT_EXCLUDES.size());
@@ -59,9 +59,9 @@ public class ExclusionHelperTest {
         addEclipseDefaults(log, false, exclusion);
         assertTrue(exclusion.isEmpty());
         addEclipseDefaults(log, true, exclusion);
-        assertEquals(4, exclusion.size());
+        assertEquals(5, exclusion.size());
         addEclipseDefaults(log, true, exclusion);
-        assertEquals(4, exclusion.size());
+        assertEquals(5, exclusion.size());
     }
 
     @Test