[jira] [Updated] (FLINK-27800) addInEdge check state error

["Licho Sun (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-27800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Licho Sun updated FLINK-27800:
------------------------------
    Description: 
when add InEdge, the checkState fucntion check the edge whether is in outEdges list, this should check whether in inEdges list.

 
{code:java}
public void addInEdge(StreamEdge inEdge) {
    checkState(
            outEdges.stream().noneMatch(inEdge::equals),
            "Adding not unique edge = %s to existing outEdges = %s",
            inEdge,
            inEdges);
    if (inEdge.getTargetId() != getId()) {
        throw new IllegalArgumentException("Destination id doesn't match the StreamNode id");
    } else {
        inEdges.add(inEdge);
    }
} {code}

  was:
when add InEdge, the checkState fucntion check the edge whether is in outEdges list, this should check whether in inEdges list.

 
{code:java}
public void addInEdge(StreamEdge inEdge) {
checkState(
outEdges.stream().noneMatch(inEdge::equals),
"Adding not unique edge = %s to existing outEdges = %s",
inEdge,
inEdges);
if (inEdge.getTargetId() != getId())
{ throw new IllegalArgumentException("Destination id doesn't match the StreamNode id"); }
else
{ inEdges.add(inEdge); }
}
{code}


> addInEdge check state error
> ---------------------------
>
>                 Key: FLINK-27800
>                 URL: https://issues.apache.org/jira/browse/FLINK-27800
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Core
>    Affects Versions: 1.15.0
>            Reporter: Licho Sun
>            Priority: Major
>             Fix For: 1.15.0
>
>
> when add InEdge, the checkState fucntion check the edge whether is in outEdges list, this should check whether in inEdges list.
>  
> {code:java}
> public void addInEdge(StreamEdge inEdge) {
>     checkState(
>             outEdges.stream().noneMatch(inEdge::equals),
>             "Adding not unique edge = %s to existing outEdges = %s",
>             inEdge,
>             inEdges);
>     if (inEdge.getTargetId() != getId()) {
>         throw new IllegalArgumentException("Destination id doesn't match the StreamNode id");
>     } else {
>         inEdges.add(inEdge);
>     }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)