You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2022/07/14 20:13:03 UTC
[GitHub] [mina-sshd] tomaswolf opened a new pull request, #233: Fix container tests when run from the src tgz in the distribution
tomaswolf opened a new pull request, #233:
URL: https://github.com/apache/mina-sshd/pull/233
Running a "mvn clean install" from the source tar archive failed for
some container tests because unpacking the tar might not preserve
executable bits. Testcontainers need an entrypoint that is executable,
or otherwise the entrypoint script must not be run directly but via
a shell explicitly.
Rewrite the two problematic tests to ensure the entrypoint script is
always executable, irrespective of whether the test resource has the
bit set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet merged pull request #233: Fix container tests when run from the src tgz in the distribution
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #233:
URL: https://github.com/apache/mina-sshd/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #233: Fix container tests when run from the src tgz in the distribution
Posted by GitBox <gi...@apache.org>.
tomaswolf commented on PR #233:
URL: https://github.com/apache/mina-sshd/pull/233#issuecomment-1184859197
@gnodet, @elecharny : this should fix the problem noticed in the 2.9.0 release candidate [on the dev mailing list](https://www.mail-archive.com/dev@mina.apache.org/msg38601.html). At least for `ClientOpenSSHCertificatesTest.java` that problem should have existed already in 2.8.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org