You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/07/12 20:21:58 UTC

[PR] CAMEL-24029: Fix flaky camel-core tests using timed assertions [camel]

gnodet opened a new pull request, #24630:
URL: https://github.com/apache/camel/pull/24630

   ## Summary
   
   Fix three flaky camel-core tests identified by [Develocity](https://develocity.apache.org):
   
   - **StopRouteAbortAfterTimeoutTest**: Use `MockEndpoint.assertIsSatisfied(context, 30, TimeUnit.SECONDS)` instead of untimed `mockEP.assertIsSatisfied()` — the SEDA consumer with 100ms delay can be slow on CI
   - **LoopNoBreakOnShutdownTest**: Increase Awaitility timeout from 1s to 10s — the async seda handoff can lag on slow CI
   - **DefaultCamelContextSuspendResumeRouteTest**: Use timed assertion after `context.resume()` — the SEDA consumer needs time to restart polling after resume
   
   All three tests use `seda:` endpoints where timing depends on thread scheduling, making them vulnerable to CI jitter.
   
   ## Test plan
   
   - [x] All three tests pass locally with `mvn test -pl core/camel-core`
   - [ ] CI passes
   
   _Claude Code on behalf of gnodet_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24029: Fix flaky camel-core tests using timed assertions [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24630:
URL: https://github.com/apache/camel/pull/24630#issuecomment-4952738453

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `core/camel-core`
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 23 tested, 0 compile-only — current: 0 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **23 affected modules** (current approach: 0).
   
   <details><summary>:warning: Modules only in Scalpel (23)</summary>
   
   - `camel-console`
   - `camel-core`
   - `camel-csimple-joor`
   - `camel-datasonnet`
   - `camel-groovy`
   - `camel-hl7`
   - `camel-javascript`
   - `camel-joor`
   - `camel-jq`
   - `camel-jsonpath`
   - `camel-main`
   - `camel-management`
   - `camel-mvel`
   - `camel-ognl`
   - `camel-platform-http-jolokia`
   - `camel-python`
   - `camel-saxon`
   - `camel-spring-xml`
   - `camel-stax`
   - `camel-xml-io-dsl`
   - `camel-xml-jaxb-dsl`
   - `camel-xml-jaxb-dsl-test-definition`
   - `camel-xml-jaxb-dsl-test-spring`
   
   </details>
   
   **Skip-tests mode would test 23 modules** (1 direct + 22 downstream), **skip tests for 0** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (23)</summary>
   
   - `camel-console`
   - `camel-core`
   - `camel-csimple-joor`
   - `camel-datasonnet`
   - `camel-groovy`
   - `camel-hl7`
   - `camel-javascript`
   - `camel-joor`
   - `camel-jq`
   - `camel-jsonpath`
   - `camel-main`
   - `camel-management`
   - `camel-mvel`
   - `camel-ognl`
   - `camel-platform-http-jolokia`
   - `camel-python`
   - `camel-saxon`
   - `camel-spring-xml`
   - `camel-stax`
   - `camel-xml-io-dsl`
   - `camel-xml-jaxb-dsl`
   - `camel-xml-jaxb-dsl-test-definition`
   - `camel-xml-jaxb-dsl-test-spring`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   :warning: **Some tests are disabled on GitHub Actions** (`@DisabledIfSystemProperty(named = "ci.env.name")`) and require manual verification:
   
   - `core/camel-core`: 2 test(s) disabled on GitHub Actions
   
   <details><summary>All tested modules (23 modules)</summary>
   
   - Camel :: Console
   - Camel :: Core
   - Camel :: DataSonnet
   - Camel :: Groovy
   - Camel :: HL7
   - Camel :: JQ
   - Camel :: JSon Path
   - Camel :: JavaScript
   - Camel :: MVEL
   - Camel :: Main
   - Camel :: Management
   - Camel :: OGNL (deprecated)
   - Camel :: Platform HTTP :: Jolokia
   - Camel :: Python
   - Camel :: Saxon
   - Camel :: Spring XML
   - Camel :: StAX
   - Camel :: XML DSL Jaxb :: Test :: Definition
   - Camel :: XML DSL Jaxb :: Test :: Spring
   - Camel :: XML DSL with camel-xml-io
   - Camel :: XML DSL with camel-xml-jaxb
   - Camel :: csimple jOOR (deprecated)
   - Camel :: jOOR
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/29207582436)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24029: Fix flaky camel-core tests using timed assertions [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24630:
URL: https://github.com/apache/camel/pull/24630#issuecomment-4952636906

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-24029: Fix flaky camel-core tests using timed assertions [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #24630:
URL: https://github.com/apache/camel/pull/24630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org