[GitHub] [maven] gnodet commented on pull request #1210: [MNG-7851] Improve error message when modelVersion is 4.0

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on PR #1210:
URL: https://github.com/apache/maven/pull/1210#issuecomment-1687527207

   > If we're going litteral, shouldn't we simply check that the version in the model is one of the supported version. The `validateModelVersion` could be simplified to just check the version is supported or thrown an exception without having to check for newer / older versions.
   
   @candrews could you simplify the code for the [`validateModelVersion`](https://github.com/apache/maven/blob/78da8ff662d9c9e0ba87aa2138114d8fd393855c/maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java#L1383-L1460) method so that it simply checks if the version is in the provided set instead (third branch of the tests) instead of comparing with all other versions ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org