[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20226: [v1.x] ONNX export support for RNN and sum_axis

[GitBox <gi...@apache.org>]

josephevans commented on a change in pull request #20226:
URL: https://github.com/apache/incubator-mxnet/pull/20226#discussion_r623386267



##########
File path: python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
##########
@@ -2168,6 +2168,12 @@ def convert_sum(node, **kwargs):
         )
     return [node]
 
+@mx_op.register("sum_axis")
+def convert_sum_axis(node, **kwargs):
+    """Map MXNet's sum_axis operator.
+       sum_axis is equivalent to sum in MXNet
+    """
+    return convert_sum(node, **kwargs)

Review comment:
       Instead of wrapping convert_sum() here, couldn't we just add the decorator to register "sum_axis" to convert_sum() ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org