[GitHub] [incubator-druid] surekhasaharan commented on issue #6358: Interning in SQLMetadataSegmentManager may obliterate new segment metadata

[GitBox <gi...@apache.org>]

surekhasaharan commented on issue #6358: Interning in SQLMetadataSegmentManager may obliterate new segment metadata
URL: https://github.com/apache/incubator-druid/issues/6358#issuecomment-488838372
 
 
   @leventov checking my understanding for this fix, so the equals in `DataSegment` should be either removed or modified to include not just the `SegmentId` equality, but other fields of `DataSegment` ?  And the `replaceWithExistingSegmentIfPresent` in `SQLMetadataSegmentManager` might return something like 
   ```
   return alreadyExistingSegment != null
              ? (alreadyExistingSegment.equals(segment) ? alreadyExistingSegment : segment)
              : segment;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org