You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/18 14:15:43 UTC

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

cuspymd commented on a change in pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615405020



##########
File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java
##########
@@ -102,7 +102,7 @@ public void testSparkShinyApp() throws IOException, InterpreterException, Interr
     Thread.sleep(5 * 1000);
     // extract shiny url
     List<InterpreterResultMessage> resultMessages = context2.out.toInterpreterResultMessage();
-    assertEquals(1, resultMessages.size());
+    assertEquals(resultMessages + "", 1, resultMessages.size());

Review comment:
       The result seems be the same as `resultMessages.toString()`, but wouldn't it be better to use a consistent expression with other code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org